Contributing to Notification Service

Thank you for your interest in contributing to the Notification Service! This document provides guidelines and instructions for contributing.

Table of Contents

• Code of Conduct
• Getting Started
• Development Workflow
• Commit Guidelines
• Pull Request Process
• Coding Standards
• Testing
• Documentation

Code of Conduct

Please be respectful and constructive in all interactions. We're all here to build something great together.

Getting Started

Prerequisites

• Node.js 24+
• Docker and Docker Compose
• Git

Setup

1. Fork the repository

   Click the "Fork" button on GitHub to create your own copy.

2. Clone your fork

   git clone https://github.com/YOUR_USERNAME/notification-service.git
   cd notification-service
   Copy

3. Install dependencies

   npm install
   Copy

4. Setup git hooks

   npm run init-hooks
   Copy

5. Configure environment

   cp .env.example .env
   # Edit .env with your settings (especially SMTP for email testing)
   Copy

6. Start dependencies

   docker-compose up -d db rabbitmq
   Copy

7. Run database migrations

   psql $DATABASE_URL -f migrations/01_create_notifications_table.sql
   psql $DATABASE_URL -f migrations/02_create_notification_statuses_table.sql
   Copy

8. Start development server

   npm run dev          # API server
   npm run dev:workers  # Workers (separate terminal)
   Copy

For detailed setup instructions, see Development Setup.

Development Workflow

1. Create a branch

git checkout -b feat/your-feature-name
# or
git checkout -b fix/your-bug-fix
Copy

Branch naming conventions:

• feat/ - New features
• fix/ - Bug fixes
• docs/ - Documentation changes
• refactor/ - Code refactoring
• test/ - Test additions/changes
• chore/ - Maintenance tasks

2. Make your changes

• Follow the coding standards
• Write tests for new functionality
• Update documentation if needed

3. Run checks

npm run lint        # Check for linting errors
npm run lint:fix    # Auto-fix linting errors
npm run format      # Format code with Prettier
npm test            # Run tests
Copy

4. Commit your changes

git add .
git commit -m "feat: add amazing feature"
Copy

See Commit Guidelines for message format.

5. Push and create PR

git push origin feat/your-feature-name
Copy

Then open a Pull Request on GitHub.

Commit Guidelines

We use Conventional Commits format:

<type>: <subject>

[optional body]

[optional footer]
Copy

Types

Examples

# Feature
git commit -m "feat: add SMS notification support"

# Bug fix
git commit -m "fix: resolve email template rendering issue"

# Documentation
git commit -m "docs: update API examples"

# With body
git commit -m "feat: add webhook callbacks

- Add callbackUrl field to notification request
- Implement HTTP POST to callback URL on status change
- Add retry logic for failed callbacks

Closes #42"
Copy

Rules

• Use lowercase for type and subject
• No period at the end of subject
• Keep subject under 72 characters
• Use imperative mood ("add" not "added")

Pull Request Process

Before submitting

• Code follows project style guide
• All tests pass (npm test)
• No linting errors (npm run lint)
• Code is formatted (npm run format)
• Documentation updated (if needed)
• Commit messages follow conventions

PR Description Template

## Summary
Brief description of changes

## Changes
- Added feature X
- Fixed bug Y
- Updated documentation Z

## Testing
- [ ] Unit tests added/updated
- [ ] Manual testing completed

## Screenshots (if applicable)

## Related Issues
Closes #123
Copy

Review Process

1. Submit PR against main branch
2. Wait for CI checks to pass
3. Address reviewer feedback
4. Maintainer will merge when approved

Coding Standards

See Coding Standards for detailed guidelines.

Quick Reference

• TypeScript: Use explicit types, avoid any
• Functions: Keep small (< 50 lines), single responsibility
• Errors: Use custom error classes, let errors bubble up
• Logging: Use structured logs with context
• Database: Always use parameterized queries
• Tests: Follow Arrange-Act-Assert pattern

File Structure

// 1. Imports
import express from 'express';

// 2. Types/Interfaces
interface NotificationData { ... }

// 3. Constants
const MAX_RETRIES = 3;

// 4. Functions/Classes
class NotificationService { ... }

// 5. Exports
export default new NotificationService();
Copy

Testing

Running Tests

npm test              # Run all tests
npm run test:watch    # Watch mode
npm run test:coverage # With coverage report
Copy

Writing Tests

• Place tests in src/__tests__/
• Name files as *.test.ts
• Use descriptive test names
• Mock external dependencies

describe('NotificationRepository', () => {
  describe('create', () => {
    it('should create notification with valid data', async () => {
      // Arrange
      const data = { ... };
      
      // Act
      const result = await repository.create(data);
      
      // Assert
      expect(result.id).toBeDefined();
    });
  });
});
Copy

Documentation

When to Update Docs

• Adding new features
• Changing API endpoints
• Modifying configuration options
• Fixing incorrect information

Documentation Files

Style Guide

• Use clear, concise language
• Include code examples
• Test all commands before documenting
• Keep examples realistic but safe

Questions?

• Check existing issues
• Open a discussion
• Create a new issue

Thank you for contributing!